Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] FMP Key Metrics #6428

Merged
merged 2 commits into from
May 17, 2024
Merged

[BugFix] FMP Key Metrics #6428

merged 2 commits into from
May 17, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • Fixes issues using with_ttm parameter.
    • Fixes field name aliases - we actually need both __alias_dict__ and alias in the Field definition.
  2. What?:

    • General model clean-up.
    • Identify more fields that are % values, and add json_schema_extra to the Field definition.
  3. Impact:

    • Expands a few field names to be more verbose.
      • roe -> return_on_equity
  4. Testing Done:

    • Multiple symbols
    • quarter and annual, with_ttm True/False

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels May 17, 2024
@IgorWounds IgorWounds enabled auto-merge May 17, 2024 12:49
@IgorWounds IgorWounds added this pull request to the merge queue May 17, 2024
Merged via the queue into develop with commit d903bf8 May 17, 2024
9 checks passed
@IgorWounds IgorWounds deleted the bugfix/fmp-key-metrics branch May 20, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants