Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix broken --sheet-name argument #6401

Merged
merged 16 commits into from
May 14, 2024
Merged

Conversation

hjoaquim
Copy link
Contributor

  1. Why? (1-3 sentences or a bullet point list):

    • Broken --sheet-name argument
  2. What? (1-3 sentences or a bullet point list):

    • Better handling of results (which may or may not be OBBjects)
    • sheet-name needed to be converted from a list to a string.
  3. Impact (1-2 sentences or a bullet point list):

    • Buf fix -> ux improvement.
  4. Testing Done:

    • Writing to an Excel with a sheet name: /equity/fundamental/ $ balance --symbol MSFT --period quarter --export msft_financials.x lsx --sheet-name balance
    • Writing to an existing Excel (with another sheet name): /equity/fundamental/ $ cash --symbol MSFT --period quarter --export msft_financials.xlsx --sheet-name cash
  5. Reviewer Notes (optional):

    • Never mind the confusion with the number of commits, this was branched off in the wrong place.

@hjoaquim hjoaquim requested a review from montezdesousa May 13, 2024 11:40
@github-actions github-actions bot added the enhancement Enhancement label May 13, 2024
@deeleeramone
Copy link
Contributor

When I don't specify sheet-name, I get an error.

cannot access local variable 'sheet_name' where it is not associated with a value

@hjoaquim
Copy link
Contributor Author

When I don't specify sheet-name, I get an error.

cannot access local variable 'sheet_name' where it is not associated with a value

I believe this fixes: 45bfac2

Thank you @deeleeramone

If it still fails somehow, please share the exact command!

Copy link
Contributor

@deeleeramone deeleeramone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--sheet-name works, on to the next!

@hjoaquim hjoaquim added this pull request to the merge queue May 14, 2024
Merged via the queue into develop with commit 922fc54 May 14, 2024
7 checks passed
@IgorWounds IgorWounds deleted the feature/remove-hold branch May 14, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants