Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dart][dart-dio-next] Authentication fixes and improvements #9975

Merged
merged 5 commits into from
Jul 27, 2021

Conversation

kuhnroyal
Copy link
Contributor

Fixes #9906

  • update http mock test library
  • correctly map authentication by type and scheme
  • add new authentication interceptor for bearer scheme - this currently does the same as the OAuth interceptor
  • add tests for all authentication types except OAuth
  • use temporary test library branch until new fixes and features get merge there

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

CC @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)

* correctly map authentication by type and scheme
* add new authentication interceptor for `bearer` scheme - this currently does the same as the OAuth interceptor
* add tests for all authentication types except OAuth
* use temporary test library branch until new fixes and features get merge there
@kuhnroyal
Copy link
Contributor Author

This is ready for reviews. Just waiting for an updated release of the mock library but other than that I expect no more changes.

Copy link
Contributor

@jaumard jaumard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

Copy link
Contributor

@agilob agilob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kuhnroyal
Copy link
Contributor Author

Updated the mock library after its release. Should be good to merge once it builds.

@wing328 wing328 added this to the 5.2.1 milestone Jul 27, 2021
@wing328 wing328 merged commit 88e22b0 into OpenAPITools:master Jul 27, 2021
@kuhnroyal kuhnroyal deleted the dart-dio-next/authentication branch July 27, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Dart-dio] Basic Auth not working
4 participants