Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] [cpp-rest-sdk] Check for null values #990

Merged
merged 2 commits into from
Sep 10, 2018

Conversation

whoan
Copy link
Contributor

@whoan whoan commented Sep 7, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

It modifies the model-source.mustache file to check for null values besides the type of data which is expected. As an example, I was having some issues with a field of type string which had a null value.

FYI @ravinikam @stkrwork @fvarose @etherealjoy @MartinDelille

@whoan whoan changed the title Cpprest check null values [C++] [cpp-rest-sdk] Check for null values Sep 7, 2018
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 added this to the 3.3.0 milestone Sep 9, 2018
@wing328 wing328 merged commit 2d99836 into OpenAPITools:master Sep 10, 2018
@whoan whoan deleted the cpprest-check-null-values branch September 10, 2018 16:24
jaumard pushed a commit to jaumard/openapi-generator that referenced this pull request Sep 21, 2018
* Check whether a value is present but null

* Update Petstore sample
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* Check whether a value is present but null

* Update Petstore sample
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants