Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Swift4] Use CodeableHelper's dateformatter in encode() if configured #984

Conversation

manhhavu
Copy link
Contributor

@manhhavu manhhavu commented Sep 6, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Update Swift4's CodeableHelper to use configured dateformatter in encode() method, the same as its decode().

Opened issue: #982

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @d-date (2018/03)

Copy link

@d-date d-date left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 😊

@wing328
Copy link
Member

wing328 commented Sep 11, 2018

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328 wing328 added this to the 3.3.0 milestone Sep 11, 2018
@manhhavu
Copy link
Contributor Author

@wing328 : Thanks for the suggestion. I've added the email I used for PR as my secondary email in my Github account (as suggested in the FAQ). Let me know if there are any other issues.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My local test result looks good

@wing328
Copy link
Member

wing328 commented Sep 17, 2018

Here is the test result:

▸ Test execute Succeeded
All tests
Test Suite SwaggerClientTests.xctest started
PetAPITests
    ✓ test1CreatePet (2.201 seconds)
    ✓ test2GetPet (0.525 seconds)
    ✓ test3DeletePet (0.587 seconds)
StoreAPITests
    ✓ test1PlaceOrder (0.687 seconds)
    ✓ test2GetOrder (0.557 seconds)
    ✓ test3DeleteOrder (0.764 seconds)
    ✓ testDownloadProgress (0.497 seconds)
UserAPITests
    ✓ testLogin (0.464 seconds)
    ✓ testLogout (0.448 seconds)
    ✓ testPathParamsAreEscaped (0.000 seconds)

@wing328 wing328 merged commit 9e1dfc0 into OpenAPITools:master Sep 17, 2018
@manhhavu manhhavu deleted the swift4_codeablehelper_encode_dateformatter branch September 17, 2018 06:32
jaumard pushed a commit to jaumard/openapi-generator that referenced this pull request Sep 21, 2018
@wing328
Copy link
Member

wing328 commented Oct 2, 2018

@manhhavu thanks again for the PR, which is included in the v3.3.0 minor release: https://twitter.com/oas_generator/status/1046941449609068544

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants