Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerShell] Improve generated PowerShell examples #9836

Conversation

SimeonGerginov
Copy link
Contributor

  1. Integer default value in the examples is changed from 123 and 789 to 0.
  2. String default value is now constructed from the name of the parameter/property and the prefix My. Previously the suffix example was part of the value.
  3. Enum examples are now generated using one of the allowed values of the Enum instead of using the Initialize-* cmdlets as before.
  4. Arrays with one element result in the value directly instead of adding the @() syntax.
  5. Maps are now fully supported using the hashtable syntax in PowerShell.
  6. Models are extracted and generated in the correct order instead of nesting them on a single line when invoking the cmdlet.
  7. The verb that is used in the examples for the Models cmdlets can now be specified through an additional property. The default value remains Initialize.
  8. Classname is used instead of Name in the Models cmdlets initialization. This can be controlled through an additional boolean property which specifies whether to use Classname instead of Name.
  9. The PowerShell Samples are updated to reflect the latest example structure.
  10. The docs template for the APIs is modified as well to reflect the latest example structure.
  11. The documentation for PowerShell is changed to reflect the new additional properties.

Closes #9826
@wing328

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Jun 29, 2021

@SimeonGerginov thanks for the PR. I'll review tomorrow and merge if no question from me.

@wing328 wing328 merged commit 3663831 into OpenAPITools:master Jul 3, 2021
@wing328 wing328 changed the title [REQ][PowerShell] Improve generated PowerShell examples [PowerShell] Improve generated PowerShell examples Jul 3, 2021
@wing328
Copy link
Member

wing328 commented Jul 3, 2021

Merged into master and updated samples via 173c7ca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ][PowerShell] Improve generated PowerShell examples
2 participants