Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore modules/openapi-generator-gradle-plugin/bin/ #983

Merged
merged 1 commit into from
Sep 7, 2018

Conversation

ndbroadbent
Copy link
Contributor

I'm always seeing this in git status after compiling the project:

untracked: modules/openapi-generator-gradle-plugin/bin/

I imagine that these are build artifacts that shouldn't be checked in, so I've added it to .gitignore.

@wing328
Copy link
Member

wing328 commented Sep 6, 2018

I just clone the project into a tmp directory and run mvn clean install but I couldn't repeat what you posted above:

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] openapi-generator-project 3.3.0-SNAPSHOT ........... SUCCESS [ 14.484 s]
[INFO] openapi-generator (core library) ................... SUCCESS [01:18 min]
[INFO] openapi-generator (executable) ..................... SUCCESS [ 40.590 s]
[INFO] openapi-generator (maven-plugin) ................... SUCCESS [ 12.334 s]
[INFO] openapi-generator-gradle-plugin (maven wrapper) .... SUCCESS [ 49.396 s]
[INFO] openapi-generator-online 3.3.0-SNAPSHOT ............ SUCCESS [ 22.180 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:41 min
[INFO] Finished at: 2018-09-06T18:30:44+08:00
[INFO] ------------------------------------------------------------------------
➜  openapi-generator git:(master) git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
➜  openapi-generator git:(master)

@ndbroadbent
Copy link
Contributor Author

Hmm I'm still seeing this when I run mvn install, maybe it's my version of Java or one of the tools I'm using.

Copy link
Member

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to add this in my opinion

@wing328
Copy link
Member

wing328 commented Sep 7, 2018

Ok. I agree it may have to do with machine setup. Let's merge this to keep more users happy with contributing back to OpenAPI Generator.

@wing328 wing328 merged commit a0f8c5e into OpenAPITools:master Sep 7, 2018
@ndbroadbent
Copy link
Contributor Author

ndbroadbent commented Sep 7, 2018 via email

@wing328 wing328 added this to the 3.3.0 milestone Oct 1, 2018
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants