Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] [Native] Unify exception messages for async, add the status code #9825

Conversation

Gama11
Copy link
Contributor

@Gama11 Gama11 commented Jun 22, 2021

The template has two methods for creating API exceptions, and the enhancements from #9169 didn't make it to the async version.

  • unify the signatures of the two methods (name, arguments)
  • make sure the sync version is not generated with asyncNative
  • extract the formatting logic into a common formatExceptionMessage() method
  • add the status code to the exception message as well, not just the body
  • shortened "call received non-success response" to a more concise "call failed with"

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

The template has two methods for creating API exceptions, and the enhancements from OpenAPITools#9169 didn't make it to the async version.

- unify the signatures of the two methods (name, arguments)
- make sure the sync version is not generated with asyncNative
- extract the formatting logic into a common formatExceptionMessage() method
- add the status code to the exception message as well, not just the body
- shortened "call received non-success response" to a more concise "call failed with"
@Gama11
Copy link
Contributor Author

Gama11 commented Jun 22, 2021

The AppVeyor failure seems unrelated / master is also failing.

@wing328
Copy link
Member

wing328 commented Jun 23, 2021

cc @MosheElisha (author of #9169)

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

Copy link
Contributor

@MosheElisha MosheElisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@wing328 wing328 added this to the 5.2.0 milestone Jul 5, 2021
@wing328 wing328 merged commit 870c1e1 into OpenAPITools:master Jul 5, 2021
@Gama11 Gama11 deleted the java-native-unified-async-exception-messages branch July 5, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants