Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pry-byebug to make it easier to debug the Ruby client during development #979

Merged
merged 1 commit into from
Sep 6, 2018

Conversation

ndbroadbent
Copy link
Contributor

cc @cliffano, @zlx

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Adds the pry-byebug gem for development, which makes it much easier to debug the Ruby client if you need to check something. Add binding.pry to get a breakpoint where you can inspect variables, etc.

@ndbroadbent
Copy link
Contributor Author

@wing328 Thanks for merging my Gemfile.lock PR! I've just added another small change to make it easier to debug the Ruby client.

@wing328
Copy link
Member

wing328 commented Sep 6, 2018

@ndbroadbent the change looks good to me. Thanks for the enhancement.

@wing328 wing328 merged commit 5d25995 into OpenAPITools:master Sep 6, 2018
@wing328 wing328 added this to the 3.3.0 milestone Sep 6, 2018
@wing328
Copy link
Member

wing328 commented Oct 2, 2018

@ndbroadbent thanks again for the PR, which is included in the v3.3.0 minor release: https://twitter.com/oas_generator/status/1046941449609068544

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants