[C++][pistache] string enum code generation improvement #9786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing enum code generation; * A class that has an `anyOf` specification, in cpp side will have no members: in stead it should have a member having the type `classname_anyOf` * Thus, Its `==` operator is not present or wrongly filled * An string enum, should have a better usage, hence the `setEnumValue` * this PR, is a brigde between `stringenumclassname_anyOf` and `stringenumclassname` * `anyOf` specification is not just about `Enums`, so a better handling is needed from mustache templates, hence new template model parameter `isStringEnumContainer`
muttleyxd
reviewed
Jun 16, 2021
| {{/hasValidation}}{{/isArray}}{{/vars}}{{/isEnum}}{{#isStringEnumContainer}}{{#anyOf}}{{#-first}} | ||
| if (!m_value.validate(msg)) | ||
| { | ||
| success = false;; |
There was a problem hiding this comment.
Thanks. It is fixed.
muttleyxd
approved these changes
Jun 16, 2021
wing328
reviewed
Jun 18, 2021
modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java
Outdated
Show resolved
Hide resolved
…x-is-string-enum-container instead in the postProcessModel operation in the C++ pistache server generator?`
…atest codes and then generate samples
wing328
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
anyOfspecification, in cpp side will have no members: instead it should have a member having the typestringenumclassname_anyOf==operator is not present or wrongly filledsetEnumValuestringenumclassname_**anyOf**andstringenumclassnameanyOfspecification is not just aboutEnums, so a better handling is needed from mustache templates, hence new template model parameterisStringEnumContainer(Continuing from #1317 )
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.x@ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08)