Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust-client]: fix reqwest not support client::options #9745

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

alberthuang24
Copy link
Contributor

@alberthuang24 alberthuang24 commented Jun 10, 2021

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

fix: #9743

@alberthuang24
Copy link
Contributor Author

@paladinzh

@alberthuang24
Copy link
Contributor Author

Why no one reviews this PR...,It looks particularly simple to change

@alberthuang24
Copy link
Contributor Author

@wing328

@wing328
Copy link
Member

wing328 commented Jun 15, 2021

Did you follow item 3 in the PR checklist to update the samples so that the CI can test the change?

@alberthuang24
Copy link
Contributor Author

Did you follow item 3 in the PR checklist to update the samples so that the CI can test the change?

Sorry, I apologize for not reading the document carefully.

Now I have updated it.

@alberthuang24
Copy link
Contributor Author

@wing328

@wing328
Copy link
Member

wing328 commented Jun 16, 2021

cc @frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05)

@wing328
Copy link
Member

wing328 commented Jun 16, 2021

The change looks good to me and the CI tests (travis) passed. Thanks for the contribution.

@wing328 wing328 merged commit 5560025 into OpenAPITools:master Jun 16, 2021
@wing328 wing328 added this to the 5.2.0 milestone Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [rust-client] Unable use reqwest to generate rust client for kubernetes api
2 participants