Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[haskell][server]: Set "AnyType" to Aeson.Value #9733

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

Profpatsch
Copy link
Contributor

@Profpatsch Profpatsch commented Jun 9, 2021

AnyType would not be translated to the json value type.
This fixes that.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

`AnyType` would not be translated to the json value type.
This fixes that.
@Profpatsch
Copy link
Contributor Author

cc @f-f @mandrean @gibiansky @Fjolnir-Dvorak as previous contributors.

Haddock (the Haskell documentation generator) would choke on the
misplaced docstring. The heading has to appear inside the list.
@Profpatsch
Copy link
Contributor Author

I pushed another small fix concerning a misplaced haddock comment.

@f-f
Copy link
Contributor

f-f commented Jun 10, 2021

Sorry, it's been a long time and I'm not involved with this anymore (thank you for contributing though!)

@wing328
Copy link
Member

wing328 commented Jun 14, 2021

@Profpatsch thanks for the PR.

Tested locally and the result is good:

[INFO] --- exec-maven-plugin:1.6.0:exec (compile-test) @ HaskellServantServerTests ---
openapi-petstore> configure (lib)
Configuring openapi-petstore-0.1.0.0...
openapi-petstore> build (lib)
Preprocessing library for openapi-petstore-0.1.0.0..
Building library for openapi-petstore-0.1.0.0..
[1 of 2] Compiling OpenAPIPetstore.Types
[2 of 2] Compiling OpenAPIPetstore.API
openapi-petstore> copy/register
Installing library in /Users/williamcheng/Code/openapi-generator/samples/server/petstore/haskell-servant/.stack-work/install/x86_64-osx/83049dd954ab3eb224bb8bb53f8b4cb9c5d21f487e07dc4cb446560830507f4a/8.6.5/lib/x86_64-osx-ghc-8.6.5/openapi-petstore-0.1.0.0-6jIYP8FqYVJIycXmp8ztms
Registering library for openapi-petstore-0.1.0.0..
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 32.962 s
[INFO] Finished at: 2021-06-14T16:59:40+08:00
[INFO] ------------------------------------------------------------------------

@wing328 wing328 merged commit cdb9208 into OpenAPITools:master Jun 14, 2021
@wing328
Copy link
Member

wing328 commented Jun 14, 2021

FYI. Samples updated via 45175f0

@Profpatsch
Copy link
Contributor Author

Profpatsch commented Jun 14, 2021

Thank you!

FYI. Samples updated via 45175f0

Yes, running the samples didn’t work locally, there were errors in unrelated languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants