Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add perltidy to format Perl code #970

Merged
merged 3 commits into from
Sep 6, 2018
Merged

Add perltidy to format Perl code #970

merged 3 commits into from
Sep 6, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Sep 5, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Setup the environment variable "PERLTIDY_PATH" (e.g. export PERLTIDY_PATH=/usr/local/bin/perltidy) to use perltidy format the perl code.

@wing328 wing328 added this to the 3.3.0 milestone Sep 5, 2018
@wing328 wing328 merged commit e29f263 into master Sep 6, 2018
@wing328 wing328 deleted the add_perltidy branch September 6, 2018 06:49
@wing328
Copy link
Member Author

wing328 commented Oct 1, 2018

BREAKING CHANGE: we'll later rename the environment variable to PERL_POST_PROCESS_FILE to make it consistent with other generators.

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* add perl tidy without updating petstore samples

* incldue pl file, update samples

* use no backup option, perltidy on test.pl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant