Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift5 namespace changes #9624

Merged
merged 8 commits into from
Jun 1, 2021

Conversation

aymanbagabas
Copy link
Contributor

Based on this discussion #9583 (review)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Instead of {{projectName}}API. This removes some unnecessary naming
complexity.
When swiftUseApiNamespace is set, API classes get defined under the
projectName namespace. This does the same for models and the
Configuration class. Plus adding a deprecation warning when using the
un-namespaced variants.
Fixes: 0f5e7d1 ("Swift5 models improvements (OpenAPITools#9205)")
@aymanbagabas aymanbagabas mentioned this pull request May 30, 2021
5 tasks
@4brunu
Copy link
Contributor

4brunu commented May 31, 2021

@aymanbagabas Since this PR is big because this changes modify a lot of files in the sample projects, I opened aymanbagabas#16 to reduce the model changes, and make it easier to review this PR.

@4brunu
Copy link
Contributor

4brunu commented May 31, 2021

@aymanbagabas overall the PR looks good, I just would like to understand better the changes in the method init(from decoder: Decoder) throws before approving this PR.

@aymanbagabas
Copy link
Contributor Author

@aymanbagabas overall the PR looks good, I just would like to understand better the changes in the method init(from decoder: Decoder) throws before approving this PR.

Since we're using Codable, it's preferable to pair it with CodingKeys to encode/decode custom types as explained here. This change should've been part of 0f5e7d1 but somehow it slipped.

@4brunu
Copy link
Contributor

4brunu commented May 31, 2021

Thanks, looks good to me 👍

@wing328
Copy link
Member

wing328 commented Jun 1, 2021

@aymanbagabas can you please resolve the merge conflicts when you've time?

@4brunu
Copy link
Contributor

4brunu commented Jun 1, 2021

Thanks for fixing the merge conflicts 👍

@wing328 wing328 merged commit 9bce716 into OpenAPITools:master Jun 1, 2021
@wing328 wing328 added this to the 5.2.0 milestone Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants