Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ python-fastapi] minor improvements #9622

Merged
merged 3 commits into from
May 31, 2021
Merged

[ python-fastapi] minor improvements #9622

merged 3 commits into from
May 31, 2021

Conversation

wing328
Copy link
Member

@wing328 wing328 commented May 30, 2021

  • minor improvements
  • better code format
  • update samples

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @arun-nalla (2019/11) @spacether (2019/11)

@wing328 wing328 mentioned this pull request May 30, 2021
5 tasks
@krjakbrjak
Copy link
Contributor

@wing328 Thanks for fixing the code style and docs. Also marking it beta is a good thing I guess.

I found a typo in my original PR, you might consider adding it to this PR (or of course I can submit another one):

--- a/modules/openapi-generator/src/main/resources/python-fastapi/security_api.mustache
+++ b/modules/openapi-generator/src/main/resources/python-fastapi/security_api.mustache
@@ -34,7 +34,7 @@ oauth2_password = OAuth2PasswordBearer(
 oauth2_code = OAuth2AuthorizationCodeBearer(
     authorizationUrl="{{authorizationUrl}}",
     tokenUrl="{{tokenUrl}}",
-    refreshUrlUrl="{{refreshUrl}}",
+    refreshUrl="{{refreshUrl}}",
     scopes={
 {{#scopes}}
         "{{scope}}": "{{description}}",

@wing328
Copy link
Member Author

wing328 commented May 31, 2021

@krjakbrjak done via 49e2e14

@wing328 wing328 merged commit 32a0450 into master May 31, 2021
@wing328 wing328 deleted the pyhton-fastapi-improve branch May 31, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants