Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Swift5] Add useClasses cli option #9608

Merged
merged 2 commits into from
May 31, 2021

Conversation

aymanbagabas
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@4brunu
Copy link
Contributor

4brunu commented May 27, 2021

Looks good to me 👍
CI is failing, but it's not related to this PR.

@wing328
Copy link
Member

wing328 commented May 30, 2021

@aymanbagabas thanks for the PR. Are there supposed to be changes to the mustache templates as well?

@aymanbagabas
Copy link
Contributor Author

aymanbagabas commented May 30, 2021

@wing328 The template changes are already there from 0f5e7d1 #9205

@aymanbagabas aymanbagabas mentioned this pull request May 30, 2021
5 tasks
@wing328
Copy link
Member

wing328 commented May 31, 2021

👌

@wing328 wing328 merged commit c4df343 into OpenAPITools:master May 31, 2021
@wing328 wing328 added this to the 5.2.0 milestone May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants