Use elm-format to format Elm API client #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriktim
reviewed
Sep 4, 2018
...les/openapi-generator/src/main/java/org/openapitools/codegen/languages/ElmClientCodegen.java
Outdated
Show resolved
Hide resolved
eriktim
reviewed
Sep 4, 2018
...les/openapi-generator/src/main/java/org/openapitools/codegen/languages/ElmClientCodegen.java
Outdated
Show resolved
Hide resolved
...les/openapi-generator/src/main/java/org/openapitools/codegen/languages/ElmClientCodegen.java
Outdated
Show resolved
Hide resolved
eriktim
reviewed
Sep 4, 2018
...les/openapi-generator/src/main/java/org/openapitools/codegen/languages/ElmClientCodegen.java
Show resolved
Hide resolved
eriktim
reviewed
Sep 4, 2018
|
@wing328 If you create another PR for validating the CI this one looks good to go. |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* add elm-format support * update elm petstore samples * add trenneman to elm tech comm * replace dart class with elm class * revise elm format arguments * update petstore samples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.3.x,4.0.x. Default:master.Description of the PR
If ELM_FORMAT_PATH (environment variable) is set to
/usr/local/bin/elm-format, Elm generator will format the Elm code automatically.cc @trenneman