Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs on master #9575

Closed
wants to merge 1 commit into from
Closed

Conversation

kuhnroyal
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

CC @wing328 @AndersSpringborg

@kuhnroyal
Copy link
Contributor Author

My branch is not building, so I just want to fix this on master real quick :)

@AndersSpringborg
Copy link
Contributor

Hi, I think @wing328 already made a pull request with these changes #9560 😃

@kuhnroyal
Copy link
Contributor Author

Ah I see and I am missing more docs :) I'll close this then.

@kuhnroyal kuhnroyal closed this May 25, 2021
@kuhnroyal kuhnroyal deleted the fix-master branch May 25, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants