Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php-slim4] Switch to Packaged Body Parsing Middleware #9562

Merged
merged 3 commits into from
Dec 17, 2021

Conversation

ybelenko
Copy link
Contributor

Remove custom JSON parsing middleware and enable builtin recommended solution.
Ref: Body Parsing Middleware - Slim Framework

Closes #9337

Tests locally:

composer test && composer phpcs
> phpunit
PHPUnit 9.5.4 by Sebastian Bergmann and contributors.

Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

IIIIIIIIIIIIIIIIIIIIIIII.III.III.III.IIIIIII.IIIIIII.III.IIIIII  63 / 120 ( 52%)
III......................................................       120 / 120 (100%)

Time: 00:00.085, Memory: 8.00 MB

OK, but incomplete, skipped, or risky tests!
Tests: 120, Assertions: 143, Incomplete: 59.
> phpcs
............................... 31 / 31 (100%)


Time: 2.13 secs; Memory: 12MB

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @jebentier, @dkarlovi, @mandrean, @jfastnacht, @ackintosh, @renepardon
cc Slim4 team member @l0gicgate

@ybelenko ybelenko added Server: PHP Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels May 24, 2021
@ybelenko

This comment has been minimized.

@ybelenko ybelenko marked this pull request as draft May 25, 2021 09:38
@ybelenko ybelenko marked this pull request as ready for review August 22, 2021 10:57
@ybelenko
Copy link
Contributor Author

ybelenko commented Oct 26, 2021

Just rebased on the latest master in hope to fix CI errors, no changes from original PR.

UPD: rebased again at November 23, 2021 to fix CI errors.
UPD: rebased again at December 5, 2021 to fix CI errors.

@wing328
Copy link
Member

wing328 commented Dec 17, 2021

Sorry for the delay in merging the PR. 🙇‍♂️

@wing328 wing328 merged commit 7dbcac3 into OpenAPITools:master Dec 17, 2021
@ybelenko ybelenko deleted the 9337_php_slim4 branch December 17, 2021 08:04
@wing328 wing328 added this to the 5.3.1 milestone Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Server: PHP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[php-slim4] Switch to Packaged Body Parsing Middleware
2 participants