Typescript: fix: add paramPropertyNaming #9546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) |
amakhrov
reviewed
Jun 1, 2021
modules/openapi-generator/src/main/resources/python/model_utils.mustache
Outdated
Show resolved
Hide resolved
amakhrov
reviewed
Jun 1, 2021
modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenConstants.java
Outdated
Show resolved
Hide resolved
amakhrov
reviewed
Jun 1, 2021
...erator/src/main/java/org/openapitools/codegen/languages/AbstractTypeScriptClientCodegen.java
Outdated
Show resolved
Hide resolved
amakhrov
reviewed
Jun 1, 2021
There was a problem hiding this comment.
Thanks for your contribution!
Overall looks good to me. Just a few minor notes.
I believe existing samples are not effected, since the default value is backward compatible.
Could you please add some unit tests that would verify the new setting works as expected?
mfmarche
force-pushed
the
fix_param_naming
branch
from
eb28082
to
2364dd7
Compare
amakhrov
reviewed
Jun 2, 2021
...java/org/openapitools/codegen/typescript/typescriptnode/TypeScriptNodeClientOptionsTest.java
Show resolved
Hide resolved
Model naming conforms to the property: modelPropertyNaming, however the parameter naming scheme is currently hardcoded to camelcase. Since the parameter names are closely tied to the model properties names, is maybe desirable to use a similar naming approach. The toParamName cannot directly use the paramPropertyNaming since that will cause issues with current generated code, since the modelPropertyNaming currently defaults to "original" A new property has been created to override this behavior, named "paramPropertyNaming", and its default is set to "camelcase".
mfmarche
force-pushed
the
fix_param_naming
branch
from
2364dd7
to
8b24f35
Compare
|
Hi @amakhrov thanks for the review. Is there something I need to do next to move it along? |
macjohnny
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model naming conforms to the property: modelPropertyNaming, however the
parameter naming scheme is currently hardcoded to camelcase. Since the
parameter names are closely tied to the model properties names, is maybe
desirable to use a similar naming approach.
The parameter naming cannot directly use the modelPropertyNaming since that
will cause issues with current generated code, since the
modelPropertyNaming currently defaults to "original"
A new property has been created to override this behavior, named
"paramPropertyNaming", and its default is set to "camelcase".
This PR likely addresses: #8296
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.x