Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python][client] allow passing floats for _request_timeout #9532

Merged
merged 2 commits into from
Jun 18, 2021
Merged

[python][client] allow passing floats for _request_timeout #9532

merged 2 commits into from
Jun 18, 2021

Conversation

daniel-k
Copy link
Contributor

While several method docstrings suggested that you could pass floats for _request_timeout and the underlying urllib3.Timeout can deal with them, the code only allowed integer values so far when passed as a single number.

>>> # everything alright
>>> api.my_endpoint(_request_timeout=2)
>>>
>>> api.my_endpoint(_request_timeout=1.2)
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File ".../client/api_client.py", line 763, in __call__
    return self.callable(self, *args, **kwargs)
  File ".../client/api/my_api.py", line 344, in __list_appliances
    return self.call_with_http_info(**kwargs)
  File ".../client/api_client.py", line 810, in call_with_http_info
    self.__validate_inputs(kwargs)
  File ".../client/api_client.py", line 704, in __validate_inputs
    fixed_val = validate_and_convert_types(
  File ".../client/model_utils.py", line 1394, in validate_and_convert_types
    converted_instance = attempt_convert_item(
  File ".../client/model_utils.py", line 1269, in attempt_convert_item
    valid_classes_ordered = order_response_types(valid_classes)
  File ".../client/model_utils.py", line 900, in order_response_types
    sorted_types = sorted(
  File ".../client/model_utils.py", line 902, in <lambda>
    key=lambda class_or_instance: index_getter(class_or_instance)
  File ".../client/model_utils.py", line 898, in index_getter
    raise ApiValueError("Unsupported type: %s" % class_or_instance)
my_client.exceptions.ApiValueError: Unsupported type: <class 'tuple'>

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

CC @taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @Jyhess @arun-nalla @spacether

While several method docstrings suggested that you could pass floats for
_request_timeout and the underlying urllib3.Timeout can deal with them,
the code only allowed integer values so far when passed as a single
number.
@wing328
Copy link
Member

wing328 commented Jun 18, 2021

Travis CI failure not related to this change. CircleCI tests already fixed in the master.

@wing328 wing328 added this to the 5.2.0 milestone Jun 18, 2021
@wing328 wing328 merged commit 2e65e6f into OpenAPITools:master Jun 18, 2021
@daniel-k daniel-k deleted the fix/python-request-timeout-types branch June 18, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants