Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Erlang] return empty body for 204 #9512

Merged
merged 7 commits into from
Jun 3, 2021
Merged

[Erlang] return empty body for 204 #9512

merged 7 commits into from
Jun 3, 2021

Conversation

lixen-wg2
Copy link
Contributor

cowboy_req:reply does not allow non empty body for 204.
https://github.com/ninenines/cowboy/blob/master/src/cowboy_req.erl#L807

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented May 18, 2021

cc @tsloughter (2017/11) @jfacorro (2018/10) @robertoaloi (2018/10)

@wing328
Copy link
Member

wing328 commented Jun 3, 2021

Tested locally by updating the samples and the output compiles without issues.

I'll update the samples in another commit after merging this PR.

@wing328 wing328 merged commit cdc0076 into OpenAPITools:master Jun 3, 2021
@wmnsk wmnsk mentioned this pull request Jun 18, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants