Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Elm CI tests #95

Merged
merged 1 commit into from
May 18, 2018
Merged

Improve Elm CI tests #95

merged 1 commit into from
May 18, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented May 18, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Test each elm file using a script

@wing328 wing328 added this to the 3.0.0 milestone May 18, 2018
@eriktim
Copy link
Contributor

eriktim commented May 18, 2018

#96 needs to be merged first.

@wing328
Copy link
Member Author

wing328 commented May 18, 2018

Tested locally and the result is good:

Compiling src/Request/User.elm
Success! Compiled 2 modules.                                        
Successfully generated /dev/null
Compiling src/Request/Pet.elm
Success! Compiled 5 modules.                                        
Successfully generated /dev/null
Compiling src/Data/Category.elm
Success! Compiled 0 modules.                                        
Successfully generated /dev/null
Compiling src/Data/Order_.elm
Success! Compiled 0 modules.                                        
Successfully generated /dev/null
Compiling src/Data/Tag.elm
Success! Compiled 0 modules.                                        
Successfully generated /dev/null
Compiling src/Data/User.elm
Success! Compiled 0 modules.                                        
Successfully generated /dev/null
Compiling src/Data/ApiResponse.elm
Success! Compiled 0 modules.                                        
Successfully generated /dev/null
Compiling src/Data/Pet.elm
Success! Compiled 0 modules.                                        
Successfully generated /dev/null

@wing328 wing328 merged commit 9b05bd6 into master May 18, 2018
@wing328 wing328 deleted the elm_test_improve branch May 18, 2018 11:29
jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request May 23, 2018
* master: (36 commits)
  jaxrs-cxf-cdi: fix outer enum (OpenAPITools#131)
  Move bash argv opt to end of ags line in scripts (OpenAPITools#124)
  Reduce CI logging (OpenAPITools#119)
  Download elm dependencies without prompting user. (OpenAPITools#118)
  [aspnetcore] Make the use of Swashbuckle optional (OpenAPITools#110)
  DefaultGenerator: fix NullPointerException (OpenAPITools#109)
  [Java] use html entities in javadoc of generated code (OpenAPITools#106)
  Update PULL_REQUEST_TEMPLATE.md
  [java] Enum in array of array (OpenAPITools#66)
  Rename datatype to dataType in CodegenProperty (OpenAPITools#69)
  update elm test to compile all elm files (OpenAPITools#95)
  Fix Petstore example for Elm (OpenAPITools#96)
  Update Docker documentation (OpenAPITools#97)
  CaseFormatLambda has been added, params for Rest-assured client has been refactored (OpenAPITools#91)
  Update integration.md
  [Clojure] Add util method to set the api-context globally (OpenAPITools#93)
  [JaxRS-Java] issue with implFolder on windows, and required fields generation for containers (OpenAPITools#88)
  Set parameters allowableValues dynamically (OpenAPITools#65)
  Meta: set version for "build-helper-maven-plugin" (OpenAPITools#89)
  Fix javadoc issues in "openapi-generator" module (OpenAPITools#84)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants