Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crystal][client] Support authorization #9488

Merged
merged 4 commits into from
May 17, 2021

Conversation

YusukeHosonuma
Copy link
Contributor

Support authorization headers oauth2 and api_key.

  • Update template files.
  • Add unit test for api_client.cr. (#update_params_for_auth! only)

Note: Probably not the best, but I tried to make it work anyway.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328

@wing328
Copy link
Member

wing328 commented May 17, 2021

CircleCI failure not related to this change.

@wing328
Copy link
Member

wing328 commented May 17, 2021

LGTM. Thanks for the PR 👍

@wing328 wing328 merged commit 477926f into OpenAPITools:master May 17, 2021
@YusukeHosonuma
Copy link
Contributor Author

Thank you too for all your reviews 👍

@YusukeHosonuma YusukeHosonuma deleted the crystal/authorization branch May 17, 2021 14:06
premiumitsolution pushed a commit to premiumitsolution/openapi-generator that referenced this pull request May 26, 2021
* [crystal][client] support authorization header

* [crystal][client] update samples

* [crystal][client] update tests

* [crystal][client] add unit test for api_client.cr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants