Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swift5][client] make AnyCodable optional #9479

Merged

Conversation

4brunu
Copy link
Contributor

@4brunu 4brunu commented May 14, 2021

This PR makes the usage of AnyCodable.

If the users don't have any usage of Any in their API's, they can simply don't include the dependency AnyCodable, because it will not be needed.

This way it works for the users that need's this dependency and also for the users that don't need it.

This PR also fixes a small issue in the project.yml, when the only dependency is AnyCodable there was a missing tag dependencies:

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

@4brunu
Copy link
Contributor Author

4brunu commented May 14, 2021

CI is failing but it's not related to this PR.

@wing328
Copy link
Member

wing328 commented May 18, 2021

LGTM

@wing328 wing328 merged commit f48311d into OpenAPITools:master May 18, 2021
premiumitsolution pushed a commit to premiumitsolution/openapi-generator that referenced this pull request May 26, 2021
* [swift5][client] make AnyCodable usage optional

* [swift5][client] update sample projects
@4brunu 4brunu deleted the feature/swift-make-anycodable-optional branch June 1, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants