Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add OAuth2 to typescript template #9466

Merged
merged 2 commits into from
May 17, 2021
Merged

add OAuth2 to typescript template #9466

merged 2 commits into from
May 17, 2021

Conversation

ksvirkou-hubspot
Copy link
Contributor

@ksvirkou-hubspot ksvirkou-hubspot commented May 12, 2021

Fixes #9465

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ksvirkou-hubspot
Copy link
Contributor Author

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
This could be extended to accept a function as well, so the token is evaluated for each request, but this can be done in a separate PR

@ksvirkou-hubspot
Copy link
Contributor Author

LGTM
This could be extended to accept a function as well, so the token is evaluated for each request, but this can be done in a separate PR

Sounds reasonable
let's do that in next PRs

@ksvirkou-hubspot
Copy link
Contributor Author

What is plan for merging ?
@macjohnny

@macjohnny
Copy link
Member

Waiting for the build to succeed

Copy link
Contributor

@TiFu TiFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well! Thank you for the PR!

@macjohnny macjohnny merged commit e1ef7d4 into OpenAPITools:master May 17, 2021
@macjohnny macjohnny added this to the 5.2.0 milestone May 17, 2021
@ksvirkou-hubspot ksvirkou-hubspot deleted the feature/typeScriptOAuth branch May 18, 2021 06:27
premiumitsolution pushed a commit to premiumitsolution/openapi-generator that referenced this pull request May 26, 2021
* add OAuth to typescript

* generate samples
@bodograumann
Copy link
Contributor

Iinm, this duplicates the BasicBearer authentication.
Shouldn’t OAuth2 instead implement the authentication token flow and retrieve a token from the authentication server?
Feels like this is misunderstanding the semantics of the security definitions. :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] [typescript] OAuth2
4 participants