-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kotlin][retrofit2] replace okhttpclient with callfactory #9451
[Kotlin][retrofit2] replace okhttpclient with callfactory #9451
Conversation
Can someone explain me, what the problem with the CI build is? |
I think the problem is not related to this PR
|
@shanselm-ergon first of all, thanks for contributing to the kotlin client generator. |
The only way to keep this backwards compatible would be, to use the same parameter name |
@shanselm-ergon Thanks a lot for your explanation. |
Let's go with this. If users prefer a way to make it backward compatible, we can introduce an option (but not something I prefer to avoid having too many options for a generator) |
Looks good to me.
into this
And if the users don't use named parameters, they don't need to change nothing. |
Tested locally and the result is good:
|
[Kotlin][retrofit2] replace okhttpclient with callfactory
fixes [#9448]
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x
@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)