-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typescript-rxjs] Update servers.mustache #9449
Conversation
add hasOwnProperty checking; use const instead of var
modules/openapi-generator/src/main/resources/typescript-rxjs/servers.mustache
Outdated
Show resolved
Hide resolved
Please follow the 3rd item in the PR checklist to update the samples so that the CI can test the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved indentation problem
cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! The change looks good to me. But it seems that you also need to regenerate samples and commit the changes as a part of this PR (https://github.com/OpenAPITools/openapi-generator/blob/master/CONTRIBUTING.md#testing)
cc @denyo |
replacedUrl = replacedUrl.replace(re, this.variableConfiguration[key]); | ||
if (this.variableConfiguration.hasOwnProperty(key)) { | ||
const re = new RegExp("{" + key + "}","g"); | ||
replacedUrl = replacedUrl.replace(re, this.variableConfiguration[key]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are trailing spaces in this line. will remove these in a separate PR.
tested locally with update samples and the result is good. will update the samples in another PR. |
add hasOwnProperty checking; use const instead of var
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x