Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-rxjs] Update servers.mustache #9449

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

rainmanhhh
Copy link
Contributor

add hasOwnProperty checking; use const instead of var

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

add hasOwnProperty checking; use const instead of var
@wing328
Copy link
Member

wing328 commented May 31, 2021

Please follow the 3rd item in the PR checklist to update the samples so that the CI can test the change.

Copy link
Contributor Author

@rainmanhhh rainmanhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved indentation problem

@wing328
Copy link
Member

wing328 commented Jul 19, 2021

cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

Copy link
Contributor

@amakhrov amakhrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! The change looks good to me. But it seems that you also need to regenerate samples and commit the changes as a part of this PR (https://github.com/OpenAPITools/openapi-generator/blob/master/CONTRIBUTING.md#testing)

@macjohnny
Copy link
Member

cc @denyo

@wing328 wing328 modified the milestones: 5.2.1, 5.3.0 Aug 17, 2021
@wing328 wing328 modified the milestones: 5.3.0, 5.3.1 Oct 25, 2021
@wing328 wing328 modified the milestones: 5.3.1, 5.4.0 Dec 29, 2021
@wing328 wing328 modified the milestones: 5.4.0, 6.0.0 Jan 31, 2022
@wing328 wing328 modified the milestones: 6.0.0, 6.1.0, 6.0.1 May 26, 2022
@wing328 wing328 modified the milestones: 6.0.1, 6.1.0 Jul 5, 2022
@wing328 wing328 modified the milestones: 6.1.0, 6.1.1 Sep 11, 2022
@wing328 wing328 modified the milestones: 6.1.1, 6.2.1 Sep 24, 2022
@wing328 wing328 removed this from the 6.2.1 milestone Nov 1, 2022
@wing328 wing328 added this to the 6.3.0 milestone Nov 1, 2022
@wing328 wing328 modified the milestones: 6.3.0, 6.3.1 Jan 20, 2023
@wing328 wing328 modified the milestones: 6.4.0, 6.5.0 Feb 19, 2023
@wing328 wing328 modified the milestones: 6.5.0, 6.6.0 Apr 1, 2023
@wing328 wing328 modified the milestones: 6.6.0, 7.0.0 May 11, 2023
@wing328 wing328 changed the title Update servers.mustache [typescript-rxjs] Update servers.mustache Aug 11, 2023
replacedUrl = replacedUrl.replace(re, this.variableConfiguration[key]);
if (this.variableConfiguration.hasOwnProperty(key)) {
const re = new RegExp("{" + key + "}","g");
replacedUrl = replacedUrl.replace(re, this.variableConfiguration[key]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are trailing spaces in this line. will remove these in a separate PR.

@wing328 wing328 merged commit a33c353 into OpenAPITools:master Aug 11, 2023
@wing328
Copy link
Member

wing328 commented Aug 11, 2023

tested locally with update samples and the result is good. will update the samples in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants