-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[php-mezzio-ph] PHP 8 support #9445
Conversation
- proper container support for data types - support for query parameter references and query parameter schema references - dependency update (PHP 7.3+, PathHandler 0.7+, DataTransfer 0.5+)
…dern PHP syntax - removed obsolete php-mezzio-ph samples in samples/openapi3/server/petstore/php-mezzio-ph
Tested locally and can start a server without issues
|
Some users may consider this as a breaking change and we may add a |
Thought about that :) But I believe it should be done next year after PHP 8.1 release. Currently there are three supported versions of PHP - 7.3 , 7.4 , 8.0 . By default (without |
It's hard to say what we can consider breaking changes in server codegens. If I remember correct @jimschubert thinks that server generators cannot cause breaking changes at all because users generate fresh stubs during migration anyway. |
modules/openapi-generator/src/main/resources/php-mezzio-ph/README.md.mustache
Show resolved
Hide resolved
@Articus thanks for clarifications I wasn't focused enough, didn't notice you've added two generators. That's not common codegen flow. |
* Huge update for php-mezzio-ph generator: - proper container support for data types - support for query parameter references and query parameter schema references - dependency update (PHP 7.3+, PathHandler 0.7+, DataTransfer 0.5+) * Sample regeneration after rebasing for php-mezzio-ph * - added custom CLI option for php-mezzio-ph to generate code using modern PHP syntax - removed obsolete php-mezzio-ph samples in samples/openapi3/server/petstore/php-mezzio-ph * - fixes for JavaDoc declarations that seems to break CI * - fix for outdated sample file
Huge update for php-mezzio-ph generator:
samples/openapi3/server/petstore/php-mezzio-ph
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x
cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @ybelenko @renepardon