Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++ pistache server] Support basic query handling #943

Merged

Conversation

etherealjoy
Copy link
Contributor

@etherealjoy etherealjoy commented Aug 30, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • Add helpers for primitive de-serialization
  • Remove warnings due to unneeded commas
  • Deserialize basic types in queries
  • Add dependencies chain for external libraries
  • Fixes wrong parameter passed to API Handler
  • Splitted the serialization of primitive types which are not handled by the json library

Fixes #257
Fixes #768
Fixes #638
@stkrwork @MartinDelille @wing328 @fvarose @ravinikam

Add  helpers for primitive de-serialization
Remove warnings due to unneeded commas
Deserialize basic types in queries
Add dependencies chain for external libraries
Fixes wrong parameter passed to API
@etherealjoy etherealjoy changed the title [cpp pistache server] Support basic query handling [c++ pistache server] Support basic query handling Aug 30, 2018
@etherealjoy
Copy link
Contributor Author

Missing support for ByteArray, Date and DateTime

@etherealjoy
Copy link
Contributor Author

@CyrilleBenard
Could you please check if the above items are solved?

@CyrilleBenard
Copy link

Confirmed, #257 #638 and #768 are fixed with this PR 👍

@CyrilleBenard
Copy link

I wonder why you use the Pistache::Some method, could you explain in few words ? (just to improve my knowledge)

@etherealjoy
Copy link
Contributor Author

Pistache::Some returns an Pistache::Optional so that you can check whether it is set or not set.

@etherealjoy etherealjoy added this to the 3.3.0 milestone Sep 12, 2018
@etherealjoy etherealjoy merged commit 3d4c3c5 into OpenAPITools:master Sep 12, 2018
@etherealjoy etherealjoy deleted the cpp-pistache-basic-query-support branch September 12, 2018 07:53
jaumard pushed a commit to jaumard/openapi-generator that referenced this pull request Sep 21, 2018
Support basic query handling

Add  helpers for primitive de-serialization
Remove warnings due to unneeded commas
Deserialize basic types in queries
Add dependencies chain for external libraries
Fixes wrong parameter passed to API
@wing328
Copy link
Member

wing328 commented Oct 2, 2018

@etherealjoy thanks again for the PR, which is included in the v3.3.0 minor release: https://twitter.com/oas_generator/status/1046941449609068544

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Support basic query handling

Add  helpers for primitive de-serialization
Remove warnings due to unneeded commas
Deserialize basic types in queries
Add dependencies chain for external libraries
Fixes wrong parameter passed to API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants