Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp][netcore] Handle Deserialization Asynchronously #9424

Merged
merged 1 commit into from
May 25, 2021

Conversation

Blackclaws
Copy link
Contributor

Gets rid of non async pathways that were in the middle of async pathways.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02)

@wing328
Copy link
Member

wing328 commented May 15, 2021

cc @lucamazzanti as well (new C# technical committee member)

@lucamazzanti
Copy link
Contributor

Another emprovement you can put in this PR is the .ConfigureAwait(false) after each Async method.

Use ConfigureAwait(false) , especially if you are implementing a library method, as it will avoid running a continuation on the original context. For library methods, it is a must, as they should never depend on the calling/original context for the continuation.

There are a lot of sources about that, here some links:

@Blackclaws
Copy link
Contributor Author

Another emprovement you can put in this PR is the .ConfigureAwait(false) after each Async method.

Use ConfigureAwait(false) , especially if you are implementing a library method, as it will avoid running a continuation on the original context. For library methods, it is a must, as they should never depend on the calling/original context for the continuation.

There are a lot of sources about that, here some links:

* articles: https://medium.com/bynder-tech/c-why-you-should-use-configureawait-false-in-your-library-code-d7837dce3d7f

* books: https://www.amazon.it/Enterprise-Application-Development-NET-professional-grade/dp/1800209444/ref=sr_1_1?__mk_it_IT=%C3%85M%C3%85%C5%BD%C3%95%C3%91&dchild=1&keywords=enterprise+application&qid=1621434256&sr=8-1

* libraries: https://github.com/firenero/AsyncIO/blob/master/AsyncIO/FileSystem/AsyncFile.cs

Hmm. The deserialization is in general only called from another library internal async method anyway. ConfigureAwait(false) is already called at the level of Api. So I'm not sure if it would add anything to sprinkle it all over the codebase here. We might want to do a general review of the async functionality in the generated code however.

@wing328 wing328 added this to the 5.2.0 milestone May 25, 2021
@wing328 wing328 merged commit e09409f into OpenAPITools:master May 25, 2021
premiumitsolution pushed a commit to premiumitsolution/openapi-generator that referenced this pull request May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants