[csharp-netcore][httpclient] Issues managing error statuses #9389

lucamazzanti · 2021-05-03T15:32:47Z

Comparing the behavior with Restsharp I found an issue.

When giving a bad status code 400 or higher with a content, it throws an exception trying to deserialize the type T.
When something goes wrong in the non async part, it thorws an AggregateException containing the ApiException, this is not expexted.
The rawContent contains bad data the class name of the stream printed not the content.

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master, 5.1.x, 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Blackclaws

wing328 · 2021-05-04T10:03:11Z

@lucamazzanti thanks for the PR. Can you please also update the samples so that the CI can verify the change?

lucamazzanti · 2021-05-04T10:06:03Z

Sorry now is completely done.

wing328 · 2021-05-04T10:11:24Z

Suggestion: what about adding a test or 2 with GetPetById on ID that doesn't exist (e.g. 99999) to trigger an exception (404) in https://github.com/OpenAPITools/openapi-generator/blob/master/samples/client/petstore/csharp-netcore/OpenAPIClient-httpclient/src/Org.OpenAPITools.Test/Api/PetApiTests.cs ?

lucamazzanti · 2021-05-04T10:12:02Z

I'll do it right now

lucamazzanti · 2021-05-04T15:23:43Z

I added two samples to test the ApiException in case of 404, one with HttpInfo with the ExceptionFactory disabled to read the result, one simple that throws ApiException. I tried to mantain the same code sintax.

Then, to test all the basic features, I rewritten for my company the test class, adding more tests on the not async part etc, ...
I added it as PetApiTestV2, and is to delete before closing the task, but take a look maybe we can refactor the csharp tests the same way or similar.

wing328 · 2021-05-04T16:01:44Z

samples/server/petstore/aspnetcore-5.0/Org.OpenAPITools.sln

+	EndGlobalSection
+	GlobalSection(ExtensibilityGlobals) = postSolution
+		SolutionGuid = {6AC7DED5-0F52-4187-9BC1-74437AAEE42D}
+	EndGlobalSection


Hmm....why there are changes to this file? Did you open this solution with VS 16?

VS 15 is Visual Studio 2017
VS 16 is Visual Studio 2019
I opened it with the latest one patch of 2019.
But the commit after i rolledback it running the scripts.

Blackclaws · 2021-05-04T16:39:42Z

I'd say remove the GetAwaiter.GetResult and just make the methods async. The reason they weren't made async originally is because they were still being used by the RestSharp code. As this now lives inside its own library folder we can just go ahead and turn the deserializer into async methods which should solve the issue with your aggregate exceptions

wing328 · 2021-05-05T02:39:13Z

Appveyor CI failed with the following error messages (partial):

----- Inner Stack Trace -----
   at System.Net.Http.ConnectHelper.ConnectAsync(String host, Int32 port, CancellationToken cancellationToken)
  Skipped Org.OpenAPITools.Test.Api.PetApiTests.UploadFileAsync_UploadFileUsingFormParameters_UpdatesTheFields [1 ms]
[xUnit.net 00:00:22.16]     Org.OpenAPITools.Test.Api.PetApiTests.AddPet_GivenExistentId_UpdateThePet [FAIL]
  Failed Org.OpenAPITools.Test.Api.PetApiTests.AddPet_GivenExistentId_UpdateThePet [1 ms]
  Error Message:
   System.Net.Http.HttpRequestException : No connection could be made because the target machine actively refused it.
---- System.Net.Sockets.SocketException : No connection could be made because the target machine actively refused it.
  Stack Trace:
     at System.Net.Http.ConnectHelper.ConnectAsync(String host, Int32 port, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean allowHttp2, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.GetHttpConnectionAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.SendWithRetryAsync(HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.FinishSendAsyncBuffered(Task`1 sendTask, HttpRequestMessage request, CancellationTokenSource cts, Boolean disposeCts)
   at Org.OpenAPITools.Client.ApiClient.ExecAsync[T](HttpRequestMessage req, IReadableConfiguration configuration, CancellationToken cancellationToken) in C:\projects\openapi-generator\samples\client\petstore\csharp-netcore\OpenAPIClient-httpclient\src\Org.OpenAPITools\Client\ApiClient.cs:line 505
   at Org.OpenAPITools.Client.ApiClient.Exec[T](HttpRequestMessage req, IReadableConfiguration configuration) in C:\projects\openapi-generator\samples\client\petstore\csharp-netcore\OpenAPIClient-httpclient\src\Org.OpenAPITools\Client\ApiClient.cs:line 447
   at Org.OpenAPITools.Client.ApiClient.Post[T](String path, RequestOptions options, IReadableConfiguration configuration) in C:\projects\openapi-generator\samples\client\petstore\csharp-netcore\OpenAPIClient-httpclient\src\Org.OpenAPITools\Client\ApiClient.cs:line 663
   at Org.OpenAPITools.Api.PetApi.AddPetWithHttpInfo(Pet pet) in C:\projects\openapi-generator\samples\client\petstore\csharp-netcore\OpenAPIClient-httpclient\src\Org.OpenAPITools\Api\PetApi.cs:line 724
   at Org.OpenAPITools.Api.PetApi.AddPet(Pet pet) in C:\projects\openapi-generator\samples\client\petstore\csharp-netcore\OpenAPIClient-httpclient\src\Org.OpenAPITools\Api\PetApi.cs:line 666
   at Org.OpenAPITools.Test.Api.PetApiTests..ctor() in C:\projects\openapi-generator\samples\client\petstore\csharp-netcore\OpenAPIClient-httpclient\src\Org.OpenAPITools.Test\Api\PetApiTestsV2.cs:line 53
----- Inner Stack Trace -----
   at System.Net.Http.ConnectHelper.ConnectAsync(String host, Int32 port, CancellationToken cancellationToken)
[xUnit.net 00:00:23.22]     Org.OpenAPITools.Test.Api.PetApiTests.GetPetByIdAsync_GivenNotExistentId_ThrowsApiException [FAIL]
[xUnit.net 00:00:24.25]     Org.OpenAPITools.Test.Api.PetApiTests.GetPetByIdWithHttpInfoAsync_GivenNotExistentId_ThrowsApiException [FAIL]
  Failed Org.OpenAPITools.Test.Api.PetApiTests.GetPetByIdAsync_GivenNotExistentId_ThrowsApiException [1 ms]
  Error Message:
   System.Net.Http.HttpRequestException : No connection could be made because the target machine actively refused it.
---- System.Net.Sockets.SocketException : No connection could be made because the target machine actively refused it.
  Stack Trace:
     at System.Net.Http.ConnectHelper.ConnectAsync(String host, Int32 port, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean allowHttp2, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.GetHttpConnectionAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.SendWithRetryAsync(HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.FinishSendAsyncBuffered(Task`1 sendTask, HttpRequestMessage request, CancellationTokenSource cts, Boolean disposeCts)
   at Org.OpenAPITools.Client.ApiClient.ExecAsync[T](HttpRequestMessage req, IReadableConfiguration configuration, CancellationToken cancellationToken) in C:\projects\openapi-generator\samples\client\petstore\csharp-netcore\OpenAPIClient-httpclient\src\Org.OpenAPITools\Client\ApiClient.cs:line 505
   at Org.OpenAPITools.Client.ApiClient.Exec[T](HttpRequestMessage req, IReadableConfiguration configuration) in C:\projects\openapi-generator\samples\client\petstore\csharp-netcore\OpenAPIClient-httpclient\src\Org.OpenAPITools\Client\ApiClient.cs:line 447
   at Org.OpenAPITools.Client.ApiClient.Post[T](String path, RequestOptions options, IReadableConfiguration configuration) in C:\projects\openapi-generator\samples\client\petstore\csharp-netcore\OpenAPIClient-httpclient\src\Org.OpenAPITools\Client\ApiClient.cs:line 663
   at Org.OpenAPITools.Api.PetApi.AddPetWithHttpInfo(Pet pet) in C:\projects\openapi-generator\samples\client\petstore\csharp-netcore\OpenAPIClient-httpclient\src\Org.OpenAPITools\Api\PetApi.cs:line 724
   at Org.OpenAPITools.Api.PetApi.AddPet(Pet pet) in C:\projects\openapi-generator\samples\client\petstore\csharp-netcore\OpenAPIClient-httpclient\src\Org.OpenAPITools\Api\PetApi.cs:line 666
   at Org.OpenAPITools.Test.Api.PetApiTests..ctor() in C:\projects\openapi-generator\samples\client\petstore\csharp-netcore\OpenAPIClient-httpclient\src\Org.OpenAPITools.Test\Api\PetApiTestsV2.cs:line 53
----- Inner Stack Trace -----
   at System.Net.Http.ConnectHelper.ConnectAsync(String host, Int32 port, CancellationToken cancellationToken)
  Failed Org.OpenAPITools.Test.Api.PetApiTests.GetPetByIdWithHttpInfoAsync_GivenNotExistentId_ThrowsApiException [1 ms]
  Error Message:
   System.Net.Http.HttpRequestException : No connection could be made because the target machine actively refused it.
---- System.Net.Sockets.SocketException : No connection could be made because the target machine actively refused it.
  Stack Trace:
     at System.Net.Http.ConnectHelper.ConnectAsync(String host, Int32 port, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean allowHttp2, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.GetHttpConnectionAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.SendWithRetryAsync(HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.FinishSendAsyncBuffered(Task`1 sendTask, HttpRequestMessage request, CancellationTokenSource cts, Boolean disposeCts)
   at Org.OpenAPITools.Client.ApiClient.ExecAsync[T](HttpRequestMessage req, IReadableConfiguration configuration, CancellationToken cancellationToken) in C:\projects\openapi-generator\samples\client\petstore\csharp-netcore\OpenAPIClient-httpclient\src\Org.OpenAPITools\Client\ApiClient.cs:line 505
   at Org.OpenAPITools.Client.ApiClient.Exec[T](HttpRequestMessage req, IReadableConfiguration configuration) in C:\projects\openapi-generator\samples\client\petstore\csharp-netcore\OpenAPIClient-httpclient\src\Org.OpenAPITools\Client\ApiClient.cs:line 447
   at Org.OpenAPITools.Client.ApiClient.Post[T](String path, RequestOptions options, IReadableConfiguration configuration) in C:\projects\openapi-generator\samples\client\petstore\csharp-netcore\OpenAPIClient-httpclient\src\Org.OpenAPITools\Client\ApiClient.cs:line 663
   at Org.OpenAPITools.Api.PetApi.AddPetWithHttpInfo(Pet pet) in C:\projects\openapi-generator\samples\client\petstore\csharp-netcore\OpenAPIClient-httpclient\src\Org.OpenAPITools\Api\PetApi.cs:line 724
   at Org.OpenAPITools.Api.PetApi.AddPet(Pet pet) in C:\projects\openapi-generator\samples\client\petstore\csharp-netcore\OpenAPIClient-httpclient\src\Org.OpenAPITools\Api\PetApi.cs:line 666
   at Org.OpenAPITools.Test.Api.PetApiTests..ctor() in C:\projects\openapi-generator\samples\client\petstore\csharp-netcore\OpenAPIClient-httpclient\src\Org.OpenAPITools.Test\Api\PetApiTestsV2.cs:line 53
----- Inner Stack Trace -----
   at System.Net.Http.ConnectHelper.ConnectAsync(String host, Int32 port, CancellationToken cancellationToken)
Failed!  - Failed:    24, Passed:   318, Skipped:     5, Total:   347, Duration: 2 s - Org.OpenAPITools.Test.dll (netcoreapp3.0)

Ref: https://ci.appveyor.com/project/WilliamCheng/openapi-generator/builds/39001191

lucamazzanti · 2021-05-05T04:28:15Z

It seems a transient error during the integration test, the previous test was fine and nothing changes of iimpacting, the message also is clear. I will test it locally to ensure it is right to propagate an HttpRequestException or convert it to an ApiException, comparing to the RestApi version. On wich server they run? The public official one or during tests the global configuration changes to a temporary server?
I'll check also the drdrone git error.

lucamazzanti · 2021-05-05T08:26:21Z

I need help I probably don't understand the complete cycle of CI.
I launched the same tests on master and I have the same issue I had yesterday that moved me to create a new test class.

master branch

the deafult configuration in the test project point to a base path in http: http://petstore.swagger.io:80/v2
the setup for each integration tests tries to add a pet
there is a 302 redirection to the https address
the call receives an 405 error, because the web method is GET and not a POST
the deserializer tries to deserialize the supporting 302 message in Pet and generates error

this PR

I let unchanged everithing in the PetApiTests class so the behavior is similar, but not for the deserializer error part (for my fix)
I created a new class PetApiTestsV2 to test isolated and changed the basepath to https and it works
A few tests I tried to reproduce from the original class generate issues server side, so I decorated them to be ignored but invain

I see in the history that both appveyor configuration and test project are not changed recently so probably I'm missing something or the public server used for the integration tests changed forcing the https in those days.
Do you have an hint? I'm available also on Slack as @luca Mazzanti

wing328 · 2021-05-05T08:40:21Z

The public API server won't work with our tests. You will need to setup run your petstore server locally:

docker pull swaggerapi/petstore
docker run -d -e SWAGGER_HOST=http://petstore.swagger.io -e SWAGGER_BASE_PATH=/v2 -p 80:8080 swaggerapi/petstore

add add the following in the host table:

127.0.0.1    petstore.swagger.io

lucamazzanti · 2021-05-05T08:42:42Z

Sorry I read now the guide: https://github.com/OpenAPITools/openapi-generator/wiki/Integration-Tests

lucamazzanti · 2021-05-05T09:05:35Z

Thank you I found the two issues I put inside the test project and rolledback.

wing328 · 2021-05-05T10:43:34Z

Can you please undo changes to the following file?

	Changes not staged for commit:
426s
5618	  (use "git add <file>..." to update what will be committed)
426s
5619	  (use "git checkout -- <file>..." to discard changes in working directory)
426s
5620	
426s
5621		modified:   samples/server/petstore/aspnetcore-5.0/Org.OpenAPITools.sln

lucamazzanti · 2021-05-05T14:20:22Z

Done

wing328 · 2021-05-06T15:49:48Z

👍

I'll merge it tomorrow before the v5.1.1 release if no one has further feedback on this PR.

lucamazzanti · 2021-05-06T15:57:31Z

Actually there is the class test PetApiTestsV2, maybe i can remove it and open a future PR to refactor the tests if useful.
Or you\we can just delete it.

wing328 · 2021-05-06T16:38:45Z

Actually there is the class test PetApiTestsV2, maybe i can remove it and open a future PR to refactor the tests if useful.

Sorry I don't understand. Why remove it? These are new tests that you added as part of this PR.

lucamazzanti · 2021-05-06T16:48:08Z

I don't know, maybe are not so similar to others or too much, and the class name is terrible. i don't want to add noise to the project. they were useful to me to certify the new client for our product.

wing328 · 2021-05-06T23:23:47Z

We can always improve the tests (naming, code style, etc) later with another PR.

lucamazzanti added 4 commits May 3, 2021 16:31

[csharp-netcore] correct rawContent read

9404742

[csharp-netcore] avoid deserialize result when in error

cea4cf9

[csharp-netcore] avoid aggregate exceptions

1ad9a74

Updated samples

0a4fcad

lucamazzanti mentioned this pull request May 4, 2021

[csharp][netcore-httpclient] Refactor of constructors: removed obsolete attribute #9373

Merged

5 tasks

wing328 added Client: C-Sharp Issue: Bug labels May 4, 2021

wing328 added this to the 5.1.1 milestone May 4, 2021

lucamazzanti added 3 commits May 4, 2021 17:14

Updated samples

baf77f9

Refactored PetApiTest

ba4f408

Updated samples

29c57a5

wing328 reviewed May 4, 2021

View reviewed changes

Fixed test issues

3aac63d

reverted previous commit

df32f0a

wing328 merged commit 2f2e250 into OpenAPITools:master May 6, 2021

lucamazzanti deleted the fix-errors branch May 7, 2021 04:50

kaburke mentioned this pull request Jul 17, 2021

[BUG][csharp-netcore]Unhandled exception when response is not 200 when using RestSharp #9966

Open

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[csharp-netcore][httpclient] Issues managing error statuses #9389

[csharp-netcore][httpclient] Issues managing error statuses #9389

lucamazzanti commented May 3, 2021

wing328 commented May 4, 2021

lucamazzanti commented May 4, 2021

wing328 commented May 4, 2021

lucamazzanti commented May 4, 2021

lucamazzanti commented May 4, 2021

wing328 May 4, 2021

lucamazzanti May 4, 2021

Blackclaws commented May 4, 2021

wing328 commented May 5, 2021

lucamazzanti commented May 5, 2021 •

edited

Loading

lucamazzanti commented May 5, 2021 •

edited

Loading

wing328 commented May 5, 2021

lucamazzanti commented May 5, 2021

lucamazzanti commented May 5, 2021

wing328 commented May 5, 2021

lucamazzanti commented May 5, 2021

wing328 commented May 6, 2021

lucamazzanti commented May 6, 2021 •

edited

Loading

wing328 commented May 6, 2021

lucamazzanti commented May 6, 2021 •

edited

Loading

wing328 commented May 6, 2021

[csharp-netcore][httpclient] Issues managing error statuses #9389

[csharp-netcore][httpclient] Issues managing error statuses #9389

Conversation

lucamazzanti commented May 3, 2021

PR checklist

wing328 commented May 4, 2021

lucamazzanti commented May 4, 2021

wing328 commented May 4, 2021

lucamazzanti commented May 4, 2021

lucamazzanti commented May 4, 2021

wing328 May 4, 2021

Choose a reason for hiding this comment

lucamazzanti May 4, 2021

Choose a reason for hiding this comment

Blackclaws commented May 4, 2021

wing328 commented May 5, 2021

lucamazzanti commented May 5, 2021 • edited Loading

lucamazzanti commented May 5, 2021 • edited Loading

master branch

this PR

wing328 commented May 5, 2021

lucamazzanti commented May 5, 2021

lucamazzanti commented May 5, 2021

wing328 commented May 5, 2021

lucamazzanti commented May 5, 2021

wing328 commented May 6, 2021

lucamazzanti commented May 6, 2021 • edited Loading

wing328 commented May 6, 2021

lucamazzanti commented May 6, 2021 • edited Loading

wing328 commented May 6, 2021

lucamazzanti commented May 5, 2021 •

edited

Loading

lucamazzanti commented May 5, 2021 •

edited

Loading

lucamazzanti commented May 6, 2021 •

edited

Loading

lucamazzanti commented May 6, 2021 •

edited

Loading