-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[elm] Add support for Elm 0.19 #937
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've pushed a commit with minor enhancements and adding Elm 0.18, 0.19 to CI (travis, shippable) Shippable (elm 0.19) reports the following errors:
|
UPDATE: Travis (elm 0.18) reports the following errors:
|
Thanks @wing328! Will fix the errors. |
@trenneman all tests passed. Thanks for the enhancement! |
Upgrade NoteElm version defaults 0.19. To use 0.18, please set
|
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* [elm] Add support for Elm 0.19 * add elm 0.18 samples, update cli option * fix elm 0.18 compile test * [elm] 0.19 fixes & improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.3.x
,4.0.x
. Default:master
.Copied the technical committee to review the pull request if your PR is targeting a particular programming language.Description of the PR
Add support for Elm 0.19. An option
elmVersion
is added to set the desired Elm version (defaults to 0.19). @wing328 can you handle the CI stuff via #878? I already added the Elm 0.19 binary to Shippable.After this PR gets merged I will work on some other open Elm issues.