Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][WebClient] add ResponseEntity return for webclient #9327

Merged

Conversation

UnleashSpirit
Copy link
Contributor

@UnleashSpirit UnleashSpirit commented Apr 23, 2021

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

For now we done it by overriding templates but as I have a bit of time and I found that there is already an issue about that, I propose this PR
fix: #5599

For review (java) :
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

@UnleashSpirit UnleashSpirit force-pushed the feature/webclient-withhttpinfo branch 2 times, most recently from cb806f0 to 8fae191 Compare April 26, 2021 07:47
@lincetto
Copy link

lincetto commented May 7, 2021

Is it possible to give a boost to this PR? Thanks :)

@UnleashSpirit UnleashSpirit force-pushed the feature/webclient-withhttpinfo branch from 8fae191 to b245495 Compare May 17, 2021 06:32
@UnleashSpirit
Copy link
Contributor Author

Hi, I rebase my branch with latest master to be up to date but CircleCI failed.
I don't know why, all tests are good in local, any ideas ?

@UnleashSpirit UnleashSpirit changed the title feat: add ResponseEntity return for webclient [Java][WebClient] add ResponseEntity return for webclient May 27, 2021
@UnleashSpirit
Copy link
Contributor Author

Any news about this PR ?
May it be include in 5.2.2 milestone (like PR #9329)

@UnleashSpirit UnleashSpirit force-pushed the feature/webclient-withhttpinfo branch from b245495 to 44aa73d Compare June 17, 2021 12:27
simplification to avoir duplicated code
@UnleashSpirit
Copy link
Contributor Author

Here a new proposal with merged function to avoid duplicated code

@wing328
Copy link
Member

wing328 commented Jun 18, 2021

LGTM

@wing328 wing328 merged commit 95a11a7 into OpenAPITools:master Jun 18, 2021
@UnleashSpirit UnleashSpirit deleted the feature/webclient-withhttpinfo branch July 16, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ][JAVA][WebClient] Generate method that returns ResponseEntity
3 participants