Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile for the Ruby-Sinatra generator #9299

Merged
merged 4 commits into from
Apr 21, 2021
Merged

Dockerfile for the Ruby-Sinatra generator #9299

merged 4 commits into from
Apr 21, 2021

Conversation

YasuhiroABE
Copy link
Contributor

I add a Dockerfile to the ruby-sinatra generator, and also update the README.md file.
To prepare these files, I needed to update the Gemfile.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@YasuhiroABE YasuhiroABE marked this pull request as ready for review April 21, 2021 01:10
@wing328 wing328 added this to the 5.1.1 milestone Apr 21, 2021
@wing328
Copy link
Member

wing328 commented Apr 21, 2021

@YasuhiroABE thanks for the PR

cc @cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)

@wing328
Copy link
Member

wing328 commented Apr 21, 2021

CircleCI failure not related to this PR.

Tested locally and the result is good.

@wing328 wing328 merged commit d4748a7 into OpenAPITools:master Apr 21, 2021
@wing328
Copy link
Member

wing328 commented Apr 21, 2021

Samples updated via 9256108

@YasuhiroABE YasuhiroABE deleted the 20210420_sinatra_dockerfile branch April 21, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants