Add postProcessFile, implement in Go generators to run gofmt #929
Conversation
|
@wing328 This changes |
|
@jimschubert the change simply adds a new function and users won't be affected. (there's no change to the existing method signatures) |
|
@jimschubert Given that next release is 3.3.0, we can do that. |
|
@wing328 when you add a new method, doesn't that break users who have written custom generators? Or will the JVM automatically pick up the new changes in the interface and DefaultCodegen, allowing those custom generators to continue working? |
|
@jimschubert right, in the worst case, it will break the usage depending on how the user customizes the project. Now it's targetting 3.3.0 (current master) |
Conflicts: CI/circle_parallel.sh shippable.yml
|
Travis error is not related to this change, it was fixed with dd35acd |
…Tools#929) * add postProcessFile, implement in Go generators to run gofmt * minor fix to docstring * update parallel job to 3
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.3.x,4.0.x. Default:master.Description of the PR
postProcessFilein Go generators to rungofmt -won each Go fileensure-up-to-datecheck to CircleCIcc @antihax (2017/11) @bvwells (2017/12) @grokify (2018/07)
cc @OpenAPITools/generator-core-team