-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add postProcessFile, implement in Go generators to run gofmt #929
Conversation
@wing328 This changes |
@jimschubert the change simply adds a new function and users won't be affected. (there's no change to the existing method signatures) |
@jimschubert Given that next release is 3.3.0, we can do that. |
@wing328 when you add a new method, doesn't that break users who have written custom generators? Or will the JVM automatically pick up the new changes in the interface and DefaultCodegen, allowing those custom generators to continue working? |
@jimschubert right, in the worst case, it will break the usage depending on how the user customizes the project. Now it's targetting 3.3.0 (current master) |
Conflicts: CI/circle_parallel.sh shippable.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not had the time to try it myself, but from a code review point of view, the change looks good.
Travis error is not related to this change, it was fixed with dd35acd |
…Tools#929) * add postProcessFile, implement in Go generators to run gofmt * minor fix to docstring * update parallel job to 3
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.3.x
,4.0.x
. Default:master
.Description of the PR
postProcessFile
in Go generators to rungofmt -w
on each Go fileensure-up-to-date
check to CircleCIcc @antihax (2017/11) @bvwells (2017/12) @grokify (2018/07)
cc @OpenAPITools/generator-core-team