Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PYTHON] Api doc python with multiple authentications #928

Merged
merged 2 commits into from
Aug 31, 2018

Conversation

rienafairefr
Copy link
Contributor

PR checklist

  • [X Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
    @taxpon @frol @mbohlool @cbornet @kenjones-cisco

Description of the PR

Looking at #919 I felt the documentation snippet for calling the api code in the python client was lacking, overriding configuration and using only the latest, this fixes it by generating a snippet for every authentication possibility

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 6bc3c70 into OpenAPITools:master Aug 31, 2018
@wing328
Copy link
Member

wing328 commented Oct 2, 2018

@rienafairefr thanks again for the PR, which is included in the v3.3.0 minor release: https://twitter.com/oas_generator/status/1046941449609068544

@rienafairefr rienafairefr deleted the api-doc-python-auth branch February 9, 2019 23:10
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* [PYTHON] better code snippet for API usage with authentication

* update python samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants