Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin jvm-retrofit2: Add missing ResponseBody import for binary responses #9239

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

ghost
Copy link

@ghost ghost commented Apr 12, 2021

This is a fix for #9238

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @jimschubert (2017/09), @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)

import okhttp3.ResponseBody

{{/isResponseFile}}
{{/operation}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, which has one limitation though. It only works if all operations have one and only one binary response. Otherwise, there will be multiple import of okhttp3.ResponseBody.

I'll see if I can come up with a better fix later with extensions.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is right. But at least it compiles and the compiler ignores the redundant lines. It was the easiest fix that we could apply by changing the template locally in our project.

Thanks for merging it!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wing328 given that you was reviewing the original PR - may I possibly ask you if the changes from the #9682 could be somehow integrated in the lib itself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants