-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dart] Improve types & imports #9167
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* don't use importMapping as it is intended for something different that is not possible in dart * introduce imports map for dart specific features * always import `dart:core` * get rid of additionalReservedWords * fix `--type-mappings` not working * use required type mappings in samples * no longer define additional reserved words as it is impossible to list all anyways, they can now be configured via type-mapping parameter * simplify dio imports
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
agilob
reviewed
Apr 4, 2021
.../openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractDartCodegen.java
Outdated
Show resolved
Hide resolved
sbu-WBT
reviewed
Apr 4, 2021
.../openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractDartCodegen.java
Show resolved
Hide resolved
Any more questions for this? |
agilob
approved these changes
Apr 6, 2021
6 tasks
The linked issue was verified as fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dart:core
--type-mappings
not workingFixes #9029
I think this is a much better solution and allows customization via CLI or config parameters.
importMapping
is meant to be used to map a class/type to that of a specific package, likeList: java.util.List
this is not possible in Dart.importMapping
is being used internally in several places and if it is miss-used in the Dart generator as it was until now, it break the possibility of specifyingtypeMappings
via CLI/config.PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x
CC @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)