Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dart] Use interrupted exception instead of just exception #9092

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Mar 26, 2021

Use interrupted exception instead of just exception

cc @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 marked this pull request as ready for review March 26, 2021 12:42
@wing328 wing328 added Client: Dart Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Mar 26, 2021
@wing328 wing328 added this to the 5.1.1 milestone Mar 26, 2021
@agilob
Copy link
Contributor

agilob commented Mar 26, 2021

@wing328 Would be nice to see a test for it :P

@wing328
Copy link
Member Author

wing328 commented Mar 26, 2021

@agilob agreed better to include a test but I can't think of a way to test it off the top of my head.

This change is actually suggested by SonarCloud Code Analysis so I think it should be pretty safe to include it.

Let's look into the test more if this is resulting in issues reported by our users.

@wing328 wing328 merged commit 5abf020 into master Mar 26, 2021
@wing328 wing328 deleted the dart-exception branch March 26, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client: Dart Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants