Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JsonIgnoreProperties to fix Infinite recursion (StackOverflowError) #903

Merged
merged 1 commit into from
Aug 27, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Aug 27, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

To fix #241

@jmini
Copy link
Member

jmini commented Aug 27, 2018

Tested with:

openapi: "3.0.0"
info:
  description: "test"
  version: "1.0.0"
  title: "myTest"

  contact:
    email: "[email protected]"

servers:
- url: "http://localhost:9998/v1"

tags:
- name: "users"

paths:
  /users/create/{username}:
    post:
      tags:
      - "user"
      operationId: "createUser"
      parameters:
      - name: "username"
        in: "path"
        required: true
        schema:
          type: "string"
      responses:
        200:
          description: "The User just created"
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/User"
components:
  schemas: 
    User:
      allOf:
        - $ref: "#/components/schemas/UserDetail"
        - type: "object"
          description: "The User"
          properties:
            id:
              type: integer
    UserDetail:
      type: "object"
      description: "Detail of a User"
      properties:
        name:
          type: "string"
          description: "the name of the user"

and this code:

@Test
public void testBuildSupportFileBundle() throws Exception {
    File output = Files.createTempDirectory("test").toFile();

    final CodegenConfigurator configurator = new CodegenConfigurator()
            .setGeneratorName("java")
            .setLibrary(JavaClientCodegen.OKHTTP_GSON)
            .setInputSpec(/* path to yaml */)
            .setOutputDir(output.getAbsolutePath().replace("\\", "/"));

    final ClientOptInput clientOptInput = configurator.toClientOptInput();
    MockDefaultGenerator generator = new MockDefaultGenerator();

    try {
        System.setProperty("debugSupportingFiles", "true");
        generator.opts(clientOptInput).generate();
    } finally {
        System.clearProperty("debugSupportingFiles");
    }
}

I wanted to add it as unit test, but the issue is only in the logs, it makes it difficult to write a unit-test for this.

@wing328
Copy link
Member Author

wing328 commented Aug 27, 2018

@jmini I've filed #904 add a test case catching the issue moving forward.

@wing328 wing328 merged commit b505795 into master Aug 27, 2018
@wing328 wing328 deleted the fix_241 branch August 27, 2018 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debugSupportingFiles causes Infinite recursion
2 participants