Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp][aspnetcore] Fix FileUpload Parameter Generation for aspnetcore #9000

Merged

Conversation

Blackclaws
Copy link
Contributor

Fix generation of operation parameters for FileUpload. We can unfortunately not use [FromX] on this type of parameter as they will then be treated as getting their individual properties from form. Stream is also not a good fit in aspnetcore as IFormFile is what we actually want.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02)

@Blackclaws Blackclaws changed the title [csharp][aspnetcore] [csharp][aspnetcore] Fix FileUpload Parameter Generation for aspnetcore Mar 18, 2021
@Blackclaws Blackclaws marked this pull request as draft March 18, 2021 13:44
@Blackclaws Blackclaws marked this pull request as ready for review March 18, 2021 23:12
@Blackclaws Blackclaws marked this pull request as draft March 18, 2021 23:14
@Blackclaws Blackclaws marked this pull request as ready for review March 18, 2021 23:38
@wing328 wing328 merged commit 46a7d97 into OpenAPITools:master Mar 22, 2021
@wing328 wing328 added this to the 5.1.1 milestone Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants