Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slim] Add PHPLint tool to check syntax #898

Merged
merged 3 commits into from
Aug 26, 2018

Conversation

ybelenko
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

PHPLint is a tool that can speed up linting of php files by running several lint processes at once.

Ref: overtrue/phplint

$ composer run phplint
> phplint ./ --exclude=vendor
phplint 1.0.2 by overtrue and contributors.

No config file loaded.

.......................................     40 / 87 (45%)
........................................     80 / 87 (91%)
........

Time: 3 secs    Memory: 2.0 MiB Cache: No

OK! (Files: 87, Success: 87)

Upgrade note

We have to increase required PHP version to 5.5.9, because it's minimum version for PHPLint tool.

cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh

There is no phplint package for PHP 5.5.0 version, so I have to increase
required PHP version to 5.5.9.
@wing328
Copy link
Member

wing328 commented Aug 26, 2018

We have to increase required PHP version to 5.5.9, because it's minimum version for PHPLint tool.

@ybelenko Given that it's a breaking change with fallback (as you've labeled), please file the PR against 3.3.x instead (you can update this PR by editing the subject line, and you will see a drop-down menu to change the target branch)

@ybelenko
Copy link
Contributor Author

@wing328
What if I've based it on current master branch and not 3.3.x. Do I need to rebase it on 3.3.x and check everything again?

@wing328
Copy link
Member

wing328 commented Aug 26, 2018

We sync changes from master to 3.3.x and then from 3.3.x to 4.0.x from time to time so you shouldn't need to rework this PR.

Please give it a try and you can always change it (target branch) to master if you want to.

@ybelenko ybelenko changed the base branch from master to 3.3.x August 26, 2018 10:01
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ybelenko ybelenko added this to the 3.3.0 milestone Aug 26, 2018
@ybelenko ybelenko merged commit e75b115 into OpenAPITools:3.3.x Aug 26, 2018
@wing328
Copy link
Member

wing328 commented Oct 2, 2018

@ybelenko thanks again for the PR, which is included in the v3.3.0 minor release: https://twitter.com/oas_generator/status/1046941449609068544

@ybelenko ybelenko deleted the slim_phplint branch November 17, 2018 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants