-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Slim] Add PHPLint tool to check syntax #898
Conversation
There is no phplint package for PHP 5.5.0 version, so I have to increase required PHP version to 5.5.9.
@ybelenko Given that it's a breaking change with fallback (as you've labeled), please file the PR against 3.3.x instead (you can update this PR by editing the subject line, and you will see a drop-down menu to change the target branch) |
@wing328 |
We sync changes from master to 3.3.x and then from 3.3.x to 4.0.x from time to time so you shouldn't need to rework this PR. Please give it a try and you can always change it (target branch) to master if you want to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
modules/openapi-generator/src/main/resources/php-slim-server/composer.mustache
Show resolved
Hide resolved
@ybelenko thanks again for the PR, which is included in the v3.3.0 minor release: https://twitter.com/oas_generator/status/1046941449609068544 |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.3.x
,4.0.x
. Default:master
.Description of the PR
PHPLint
is a tool that can speed up linting of php files by running several lint processes at once.Ref: overtrue/phplint
Upgrade note
We have to increase required PHP version to 5.5.9, because it's minimum version for
PHPLint
tool.cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh