Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bash] escape tabs properly #8970

Merged
merged 1 commit into from
Mar 27, 2021
Merged

Conversation

avbenavides
Copy link
Contributor

Bash Client Escapes parameters with a 't' to %09 and leaves tabs unescaped
Fixes #7303

Bash Client Escapes parameters with a 't' to %09 and leaves tabs unescaped

openapitools/openapi-generator-cli Version 5.0.0-SNAPSHOT

Command used to generate:

docker run --rm -v $(git rev-parse --show-toplevel)/lt-frontend/:/local openapitools/openapi-generator-cli generate \
     -i /local/spec/frontend-api.yml \
     -g bash \
     --enable-post-process-file  -o /local/clients/cli/ -p apiKeyAuthEnvironmentVariable=API_KEY,generateBashCompletion=true,hostEnvironmentVariable=API_HOST,scriptName=api,generateZshCompletion=true

Example:

API_HOST=https://load-test-int.test.ops.company.se ./api --dry-run getTestJobByName job=systest-stress-pc
curl     -X GET "https://load-test-int.test.ops.company.se/api/v1/tests/sys%09es%09-s%09ress-pc"

should be

API_HOST=https://load-test-int.test.ops.company.se ./api --dry-run getTestJobByName job=systest-stress-pc
curl     -X GET "https://load-test-int.test.ops.company.se/api/v1/tests/systest-stress-pc"

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Bash Client Escapes parameters with a 't' to %09 and leaves tabs unescaped
Fixes OpenAPITools#7303
@auto-labeler
Copy link

auto-labeler bot commented Mar 15, 2021

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@avbenavides avbenavides changed the title Update client.mustache [Bash] Update client.mustache Mar 15, 2021
@wing328
Copy link
Member

wing328 commented Mar 22, 2021

cc @frol (2017/07) @bkryza (2017/08) @kenjones-cisco (2017/09)

@wing328 wing328 added this to the 5.1.1 milestone Mar 22, 2021
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I've not tested it locally.

@wing328 wing328 merged commit 2525639 into OpenAPITools:master Mar 27, 2021
@wing328 wing328 changed the title [Bash] Update client.mustache [Bash] escape tabs properly Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bash Client Escapes parameters with a 't' to %09 and leaves tabs unescaped
2 participants