[Slim] Add PHP CodeSniffer to check coding style #897
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.3.x
,4.0.x
. Default:master
.Description of the PR
As defined in guide of contributing, PHP templates should meet PSR-2 coding style.
I've added PHP CodeSniffer package to check source code on violations against user defined standard. User can change coding standard with
phpcsStandard
config option.'PSR12'
is default(checks against PSR-1 and PSR-2)I think it's perfect time to add linters and code formatters while generator is small like Slim now. It will be easier to update templates and check them automatically every next PR. By this reason I suggest to merge this PR before #735.
cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh