Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Fix cookie support in Node.js client #895

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

delenius
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

After a change to superagent, the cookie support broke, because they renamed the attachCookies and saveCookies methods, adding underscores in the beginning.

Technically, these methods are considered "private", and this may break again. But for now, this is the easiest fix.

Technical committee:
@CodeNinjai @frol @cliffano

@wing328
Copy link
Member

wing328 commented Aug 26, 2018

@delenius thanks for the PR. Do we need to update the dependency accordingly?

@wing328
Copy link
Member

wing328 commented Aug 26, 2018

[Optional] Maybe we should take this opportunity to consider upgrading superagent to the latest version.

@wing328 wing328 merged commit 9d89387 into OpenAPITools:master Sep 4, 2018
@wing328 wing328 added this to the 3.3.0 milestone Sep 4, 2018
@wing328
Copy link
Member

wing328 commented Oct 2, 2018

@delenius thanks again for the PR, which is included in the v3.3.0 minor release: https://twitter.com/oas_generator/status/1046941449609068544

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants