Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds hasVars #8928

Merged
merged 11 commits into from
Mar 9, 2021
Merged

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Mar 8, 2021

Adds hasVars to java Schema classes
This is needed if one is generating classes for object schemas and one only wants to generate the class if properties exists.
One could almost do this with #vars but that doesn't work because using #vars mean we move into the context of iterating over each var when we just need to know if there are vars.

hasVars is tested in the below models:

  • CodegenModel
  • CodegenProperty
  • CodegenParameter
  • CodegenResponse

This will be used in:
#8325

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether spacether marked this pull request as draft March 8, 2021 16:51
@spacether spacether changed the title Adds hasVars hasRequiredVars Adds hasVars Mar 8, 2021
@spacether spacether marked this pull request as ready for review March 9, 2021 16:26
@spacether spacether added this to the 5.1.0 milestone Mar 9, 2021
@spacether spacether force-pushed the adds_hasVars_hasRequiredVars branch from 861106a to 12ddfda Compare March 9, 2021 17:55
@spacether
Copy link
Contributor Author

spacether commented Mar 9, 2021

Circle ci error with dart is odd. My code should not cause it. Rebasing and regenerating samples to see if that fixes it.

@spacether
Copy link
Contributor Author

Seeing this same issue here: #8877
It looks like master branch dart tests are failing in circleci.

@spacether
Copy link
Contributor Author

Dart error is unrelated to this PR

@spacether spacether merged commit 786c71f into OpenAPITools:master Mar 9, 2021
@spacether spacether deleted the adds_hasVars_hasRequiredVars branch March 9, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant