Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: python-asyncio/aiohttp with disabled ssl verification #891

Merged
merged 1 commit into from
Aug 24, 2018

Conversation

tomplus
Copy link
Member

@tomplus tomplus commented Aug 23, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • aiohttp doesn't accept ssl_context when ssl verification is disabled
  • regenerate python samples

PTAL: @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11)

@kenjones-cisco
Copy link
Contributor

LGTM!

@wing328
Copy link
Member

wing328 commented Aug 24, 2018

@kenjones-cisco thanks for reviewing the change.

@tomplus thanks for the fix.

@wing328 wing328 merged commit 79dacb2 into OpenAPITools:master Aug 24, 2018
@wing328
Copy link
Member

wing328 commented Aug 30, 2018

@tomplus the fix is included in the v3.2.3 release: https://twitter.com/oas_generator/status/1035200785066254336

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants