Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dart] Fix api client deserialization for json_serializable #8882

Conversation

agilob
Copy link
Contributor

@agilob agilob commented Mar 3, 2021

Oh boy I hope this works

It works

@kuhnroyal

@agilob
Copy link
Contributor Author

agilob commented Mar 8, 2021

I think this is too much of a change and should be more conditional for now... brb

@agilob
Copy link
Contributor Author

agilob commented Mar 8, 2021

Class.fromJson is only used in json_serializable not for native

…to dart-json-serializable-api-client-fix-deserialization-of-objects
@agilob
Copy link
Contributor Author

agilob commented Mar 10, 2021

@kuhnroyal bump

Copy link
Contributor

@kuhnroyal kuhnroyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@agilob agilob force-pushed the dart-json-serializable-api-client-fix-deserialization-of-objects branch from b546fd7 to 7759ae1 Compare March 11, 2021 08:44
@agilob
Copy link
Contributor Author

agilob commented Mar 11, 2021

Failure in:

[SEVERE] built_value_generator:built_value on lib/model/enum_arrays.dart:
An error `FormatterException` occurred while formatting the generated source for
  `package:openapi/model/enum_arrays.dart`
which was output to
  `lib/model/enum_arrays.built_value.g.part`.
This may indicate an issue in the generator, the input source code, or in the
source formatter.
Could not format because the source could not be parsed:

line 43, column 5: Expected an identifier.
   ╷
43 │ '\\$': 'dollar',
   │     ^
   ╵
line 39, column 15: Expected an identifier.
   ╷
39 │ 'dollar': '\\$',
   │               ^

@kuhnroyal
Copy link
Contributor

Ya, #8947 fixed this on master. Just needs a rebuild probably.

@agilob
Copy link
Contributor Author

agilob commented Mar 11, 2021

Yup, passed now after pulling master

@wing328 wing328 added this to the 5.1.0 milestone Mar 11, 2021
@wing328 wing328 merged commit b782cff into OpenAPITools:master Mar 11, 2021
@agilob agilob deleted the dart-json-serializable-api-client-fix-deserialization-of-objects branch March 11, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants