-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dart] Fix api client deserialization for json_serializable #8882
[dart] Fix api client deserialization for json_serializable #8882
Conversation
samples/client/petstore/dart2/petstore_client_lib/lib/api/user_api.dart
Outdated
Show resolved
Hide resolved
samples/openapi3/client/petstore/dart2/petstore_client_lib_fake/lib/api/fake_api.dart
Outdated
Show resolved
Hide resolved
I think this is too much of a change and should be more conditional for now... brb |
Class.fromJson is only used in json_serializable not for native |
…to dart-json-serializable-api-client-fix-deserialization-of-objects
@kuhnroyal bump |
...napi3/client/petstore/dart2/petstore_client_lib_fake/lib/api/fake_classname_tags123_api.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me
b546fd7
to
7759ae1
Compare
…to dart-json-serializable-api-client-fix-deserialization-of-objects
Failure in:
|
Ya, #8947 fixed this on master. Just needs a rebuild probably. |
Yup, passed now after pulling master |
Oh boy I hope this worksIt works
@kuhnroyal