Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Erlang][Client] better code, update sample #8853

Merged
merged 1 commit into from
Feb 28, 2021
Merged

[Erlang][Client] better code, update sample #8853

merged 1 commit into from
Feb 28, 2021

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Feb 27, 2021

  • code cleanup
  • better code comment
  • update samples

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @tsloughter (2017/11) @jfacorro (2018/10) @robertoaloi (2018/10)

@wing328 wing328 added Client: Erlang Enhancement: Code format Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Feb 27, 2021
@wing328 wing328 added this to the 5.1.0 milestone Feb 27, 2021
@jfacorro
Copy link
Contributor

I'm probably missing something, but the title says that the code sample is updated in this PR even though I couldn't find that in the diff? Is the code sample updated through the build job?

@wing328
Copy link
Member Author

wing328 commented Feb 28, 2021

@jfacorro there's only 1 minor change to the VERSION file: https://github.com/OpenAPITools/openapi-generator/pull/8853/files#diff-286a45eee4f80d6413b2841a22a46bc60b88e156f09cb673d196c2563e1802e4

which is good as the Erlang client generator has been producing the same output despite enhancements in the Default codegen class, etc

@wing328
Copy link
Member Author

wing328 commented Feb 28, 2021

@tsloughter thanks for the quick review 👍

@wing328 wing328 merged commit 125e6a4 into master Feb 28, 2021
@wing328 wing328 deleted the erlang-improve branch February 28, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client: Erlang Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Enhancement: Code format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants